Fix to C starvation by canopy layer history variables #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
approved these changes
Jan 27, 2023
|
Regression testing on cheyenne is complete. I tested this and #926 at the same time by merging them together. All expected tests pass b4b against Folder location: |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes issue #970 by updating the history variables related to carbon starvation mortality by canopy layer:
FATES_M3_MORTALITY_CANOPY_SZPF, FATES_M3_MORTALITY_CANOPY_SZ, FATES_M3_MORTALITY_USTORY_SZPF, and FATES_M3_MORTALITY_USTORY_SZ.
Collaborators:
Expectation of Answer Changes:
These values would previously be zero but should now reflect the number density of cohorts dying by carbon starvation mortality in each canopy layer. Only tested with E3SM c63cce2 and FATES e663a6e. Test results below are from my branch here:
https://github.com/JessicaNeedham/fates/tree/JFN-bagw-vars-respmod-v2
Canopy layer outputs are compared with FATES_MORTALITY_CSTARV_SZPF.
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: